Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17451
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r137368179
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125339579
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125170914
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125158303
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125158304
--- Diff: python/pyspark/ml/feature.py ---
@@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125154011
--- Diff: python/pyspark/ml/feature.py ---
@@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125154035
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125154018
--- Diff: python/pyspark/ml/feature.py ---
@@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123951868
--- Diff: python/pyspark/ml/tests.py ---
@@ -538,6 +538,19 @@ def test_rformula_force_index_label(self):
transformedDF2 = model2.transform(df)
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123951212
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123951200
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123950944
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123950871
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -230,7 +230,7 @@ class Word2VecModel private[ml] (
* Find "num"
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123950209
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123940294
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123925184
--- Diff: python/pyspark/ml/feature.py ---
@@ -2869,6 +2869,18 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123925233
--- Diff: python/pyspark/ml/feature.py ---
@@ -2869,6 +2869,18 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123925086
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r123925064
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,31 @@ class Word2VecModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r108359620
--- Diff: python/pyspark/ml/tests.py ---
@@ -389,6 +389,21 @@ def test_word2vec_param(self):
# Check windowSize is set properly
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r108359474
--- Diff: python/pyspark/ml/feature.py ---
@@ -2674,6 +2674,18 @@ def findSynonyms(self, word, num):
word = _convert_to_vector(word)
GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/17451
[SPARK-19866][ML][PySpark] Add local version of Word2Vec findSynonyms for
spark.ml: Python API
https://issues.apache.org/jira/browse/SPARK-19866
## What changes were proposed in this
23 matches
Mail list logo
