Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r111216578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -571,6 +571,7 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r111078930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -571,6 +571,7 @@ object TypeCoercion {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r110991443
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -656,14 +656,20 @@ class TypeCoercionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r110979361
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -571,6 +571,7 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r110901338
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -656,14 +656,20 @@ class TypeCoercionSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r110901088
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -656,14 +656,20 @@ class TypeCoercionSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17606#discussion_r110864960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -571,6 +571,7 @@ object TypeCoercion {
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/17606
[SPARK-20291][SQL] NaNvl(FloatType, NullType) should not be cast to
NaNvl(DoubleType, DoubleType)
## What changes were proposed in this pull request?
`NaNvl(float value, null)` will be
