[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2018-12-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r238950241 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -734,6 +734,28 @@ object CollapseWindow extends

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2018-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17899 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2018-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r215843736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -726,14 +726,36 @@ object CollapseRepartition

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r147546887 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -610,6 +611,25 @@ object CollapseWindow extends

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2017-06-30 Thread ptkool
Github user ptkool commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r125013340 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -610,6 +611,25 @@ object CollapseWindow extends

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2017-06-30 Thread ptkool
Github user ptkool commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r125013283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -610,6 +611,25 @@ object CollapseWindow extends

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2017-06-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r124966795 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -610,6 +611,25 @@ object CollapseWindow extends

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

2017-06-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17899#discussion_r124966455 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -610,6 +611,25 @@ object CollapseWindow extends