Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116906916
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -631,13 +631,13 @@ class CachedTableSuite extends QueryTest with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116851595
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116770420
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
relationPrimary
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116756100
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116742572
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
relationPrimary
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116733019
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -868,6 +868,29 @@ class SubquerySuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116732810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1066,7 +1066,7 @@ class Analyzer(
case
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116677226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1066,7 +1066,7 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116674740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -798,6 +798,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116656440
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116655663
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -868,6 +868,29 @@ class SubquerySuite extends QueryTest with
12 matches
Mail list logo