Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119775018
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
@@ -43,7 +43,6 @@ private[ml] object TreeTests extends SparkFunSuite {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119762504
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,22 +899,14 @@ object SparkSession {
// No active
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119761860
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,22 +899,14 @@ object SparkSession {
// No active
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119757139
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
@@ -43,7 +43,6 @@ private[ml] object TreeTests extends SparkFunSuite {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119724298
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,22 +899,14 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119679155
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,22 +909,13 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119646288
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,21 +904,16 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119645957
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -753,6 +753,8 @@ object SparkSession {
private[this] val
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119549608
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,21 +899,15 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119530605
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,21 +899,15 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119530328
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -935,7 +929,6 @@ object SparkSession {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119529998
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -899,21 +899,15 @@ object SparkSession {
// No active
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18172#discussion_r119529538
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
@@ -43,7 +43,6 @@ private[ml] object TreeTests extends SparkFunSuite {
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/18172
[SPARK-20946][SQL] simplify the config setting logic in
SparkSession.getOrCreate
## What changes were proposed in this pull request?
The current conf setting logic is a little complex
15 matches
Mail list logo
