Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18270
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136708766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -954,6 +954,15 @@ class Analyzer(
try {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136708762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -863,6 +854,15 @@ class Analyzer(
case q:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136708657
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -954,6 +954,15 @@ class Analyzer(
try {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136708299
--- Diff:
sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out ---
@@ -223,12 +223,19 @@ grouping_id() can only be used with
Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136695110
--- Diff:
sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out ---
@@ -223,12 +223,19 @@ grouping_id() can only be used with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136694895
--- Diff:
sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out ---
@@ -223,12 +223,19 @@ grouping_id() can only be used with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136121931
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1414,6 +1414,19 @@ class SQLQuerySuite extends
GitHub user cenyuhai reopened a pull request:
https://github.com/apache/spark/pull/18270
[SPARK-21055][SQL] replace grouping__id with grouping_id()
## What changes were proposed in this pull request?
spark does not support grouping__id, it has grouping_id() instead.
But it
Github user cenyuhai closed the pull request at:
https://github.com/apache/spark/pull/18270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r136082775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -954,6 +951,12 @@ class Analyzer(
try {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18270#discussion_r134619232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -954,6 +951,12 @@ class Analyzer(
try {
GitHub user cenyuhai opened a pull request:
https://github.com/apache/spark/pull/18270
[SPARK-21055][SQL] replace grouping__id with grouping_id()
## What changes were proposed in this pull request?
spark does not support grouping__id, it has grouping_id() instead.
But it is
13 matches
Mail list logo
