Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18281
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r134123840
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -17,29 +17,34 @@
package
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r131215571
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r131104871
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,44 @@ class OneVsRestSuite extends SparkFunSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r131104233
--- Diff: python/pyspark/ml/classification.py ---
@@ -1517,20 +1518,23 @@ class OneVsRest(Estimator, OneVsRestParams,
JavaMLReadable, JavaMLWritable):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r131102727
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r129989469
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/HasParallelism.scala ---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r129989379
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r129989332
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r129982672
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,45 @@ class OneVsRestSuite extends
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128828428
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,7 +273,7 @@ object OneVsRestModel extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128815421
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,7 +273,7 @@ object OneVsRestModel extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128708769
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,7 +273,7 @@ object OneVsRestModel extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128648171
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,7 +273,7 @@ object OneVsRestModel extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128645326
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -337,8 +353,13 @@ final class OneVsRest @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128630894
--- Diff: python/pyspark/ml/tests.py ---
@@ -1389,11 +1389,25 @@ def test_output_columns(self):
(2.0,
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128629749
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -337,8 +353,13 @@ final class OneVsRest @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128632738
--- Diff: python/pyspark/ml/classification.py ---
@@ -1564,8 +1568,9 @@ def trainSingleClass(index):
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128630645
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,45 @@ class OneVsRestSuite extends SparkFunSuite
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128632376
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,8 +1581,9 @@ def trainSingleClass(index):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128456263
--- Diff: python/pyspark/ml/tests.py ---
@@ -1389,11 +1389,25 @@ def test_output_columns(self):
(2.0,
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128455590
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,8 +1581,9 @@ def trainSingleClass(index):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128456402
--- Diff: python/pyspark/ml/tests.py ---
@@ -1389,11 +1389,25 @@ def test_output_columns(self):
(2.0,
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128453820
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128455001
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,45 @@ class OneVsRestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127753960
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127753831
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127752302
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/HasParallelism.scala ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127752074
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/HasParallelism.scala ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127753088
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127558107
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,30 @@ def test_output_columns(self):
(2.0,
Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127557890
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552088
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552778
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552478
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552072
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552824
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550679
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127553451
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,30 @@ def test_output_columns(self):
(2.0,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127551356
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +326,11 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127551019
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550735
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127553419
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550604
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550407
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550217
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125714270
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125713755
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,8 +1581,9 @@ def trainSingleClass(index):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125712843
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125711716
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125711671
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125711158
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125442664
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125442029
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125442535
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,36 @@ class OneVsRestSuite extends SparkFunSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125441401
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +328,10 @@ final class OneVsRest @Since("1.4.0") (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125443195
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
..
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125443766
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,8 +1581,9 @@ def trainSingleClass(index):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125441618
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125444096
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,22 @@ def test_output_columns(self):
(2.0,
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125441288
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -17,28 +17,31 @@
package
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125372266
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125372601
--- Diff: python/pyspark/ml/tests.py ---
@@ -1215,7 +1215,7 @@ def test_copy(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125372583
--- Diff: python/pyspark/ml/tests.py ---
@@ -951,7 +951,7 @@ def test_onevsrest(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125372433
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r125372204
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +328,10 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683930
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,22 @@ def test_output_columns(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683993
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,22 @@ def test_output_columns(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123675948
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,17 +274,40 @@ object OneVsRestModel extends
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123682836
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683590
--- Diff: python/pyspark/ml/tests.py ---
@@ -951,7 +951,7 @@ def test_onevsrest(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123682465
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683481
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123682228
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,20 +359,28 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123676033
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,20 +359,28 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123684075
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683914
--- Diff: python/pyspark/ml/tests.py ---
@@ -1215,7 +1215,7 @@ def test_copy(self):
(2.0,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123682949
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123683303
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123682535
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122543278
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122539202
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122524554
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,37 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122524395
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122524220
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122523766
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122012617
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122007474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +350,13 @@ final class OneVsRest @Since("1.4.0") (
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r122012995
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,37 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121836808
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +343,13 @@ final class OneVsRest @Since("1.4.0") (
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121790182
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +343,13 @@ final class OneVsRest @Since("1.4.0") (
91 matches
Mail list logo
