[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2018-04-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r181573285 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1761,24 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2018-04-14 Thread edlee123
Github user edlee123 commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r181567770 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1761,24 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2018-04-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r181567408 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1761,24 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2018-04-14 Thread edlee123
Github user edlee123 commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r181565606 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1761,24 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123499500 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1721,7 +1721,18 @@ def toPandas(self): 15Bob """ import

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123461244 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1721,7 +1721,18 @@ def toPandas(self): 15Bob """ import

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123445243 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1761,24 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123425404 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1721,7 +1721,14 @@ def toPandas(self): 15Bob """ import

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123399287 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1721,7 +1721,8 @@ def toPandas(self): 15Bob """ import

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123384341 --- Diff: python/pyspark/sql/tests.py --- @@ -2274,6 +2274,21 @@ def count_bucketed_cols(names, table="pyspark_bucket"):

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123380675 --- Diff: python/pyspark/sql/tests.py --- @@ -2274,6 +2274,21 @@ def count_bucketed_cols(names, table="pyspark_bucket"):

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123326970 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1750,6 +1751,29 @@ def _to_scala_map(sc, jm): return sc._jvm.PythonUtils.toScalaMap(jm)

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18378#discussion_r123325897 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1721,7 +1721,8 @@ def toPandas(self): 15Bob """ import

[GitHub] spark pull request #18378: [SPARK-21163][SQL] DataFrame.toPandas should resp...

2017-06-21 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18378 [SPARK-21163][SQL] DataFrame.toPandas should respect the data type ## What changes were proposed in this pull request? Currently we convert a spark DataFrame to Pandas Dataframe by