[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r124712549 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala --- @@ -339,6 +340,28 @@ class DatasetPrimitiveSuite extends QueryTest

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r124712535 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -834,6 +834,140 @@ case class

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r124332920 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala --- @@ -339,6 +340,28 @@ class DatasetPrimitiveSuite extends QueryTest

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r124332023 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -834,6 +834,140 @@ case class

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r123920728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -992,6 +1123,128 @@ case class

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-25 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18416 [SPARK-21204][SQL][WIP] Add support for Scala Set collection types in serialization ## What changes were proposed in this pull request? Currently we can't produce a `Dataset` containing