[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124223602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124177003 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124168400 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124165135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124163076 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124152021 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -736,7 +736,27 @@ class CodegenContext {

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124081617 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -736,7 +736,27 @@ class CodegenContext {

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-25 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18418 [SPARK-19104][SQL] Lambda variables should work when parent expression splits generated codes ## What changes were proposed in this pull request? When an expression using lambda variables