[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2018-09-11 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r216597619 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -373,8 +373,14 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2018-04-16 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r181706342 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -373,8 +373,14 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-10-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r146190420 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -373,8 +373,14 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-22 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134637603 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134634721 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-22 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134574304 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134387763 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-21 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134336371 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-21 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134334889 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134243239 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r134242290 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133786071 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +294,11 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133774907 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +294,11 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133774366 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +294,11 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133773675 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -980,10 +1014,12 @@ private object

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133726365 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -980,10 +1014,12 @@ private object

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133726091 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +294,11 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-15 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r133355548 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +297,16 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r132628227 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +297,16 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r132628016 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -291,6 +297,16 @@ private[spark] trait SparkListenerInterface {

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131822909 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -53,6 +53,12 @@ case class SparkListenerTaskStart(stageId: Int,

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131820476 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -140,6 +140,16 @@ public void onBlockUpdated(SparkListenerBlockUpdated

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131820095 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -140,6 +140,16 @@ public void onBlockUpdated(SparkListenerBlockUpdated

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131819639 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -53,6 +53,12 @@ case class SparkListenerTaskStart(stageId: Int,

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131818512 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r131602232 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-20 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128683971 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-20 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128452352 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-20 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128452499 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128339669 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -140,6 +140,16 @@ public void onBlockUpdated(SparkListenerBlockUpdated

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128338765 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -281,6 +281,20 @@ class DAGScheduler(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128338491 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128215501 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -572,20 +572,35 @@ private[spark] class

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128215419 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -140,6 +140,16 @@ public void onBlockUpdated(SparkListenerBlockUpdated

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-07-19 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r128215595 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -281,6 +281,20 @@ class DAGScheduler(

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-06-30 Thread janewangfb
GitHub user janewangfb opened a pull request: https://github.com/apache/spark/pull/18492 [SPARK-19326] Speculated task attempts do not get launched in few scenarios ## What changes were proposed in this pull request? Add a new listener event when a speculative task is