[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131293810 --- Diff: python/pyspark/ml/tests.py --- @@ -1957,6 +1988,40 @@ def test_chisquaretest(self): self.assertTrue(all(field in fieldNames for

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131223795 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,53 @@ class Model(Transformer): """ __metaclass__ = ABCMeta + +

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131222861 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,53 @@ class Model(Transformer): """ __metaclass__ = ABCMeta + +

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131258120 --- Diff: python/pyspark/ml/tests.py --- @@ -1957,6 +1987,24 @@ def test_chisquaretest(self): self.assertTrue(all(field in fieldNames for

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r13190 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,53 @@ class Model(Transformer): """ __metaclass__ = ABCMeta + +

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r13122 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,53 @@ class Model(Transformer): """ __metaclass__ = ABCMeta + +

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131258476 --- Diff: python/pyspark/ml/tests.py --- @@ -1957,6 +1987,24 @@ def test_chisquaretest(self): self.assertTrue(all(field in fieldNames for

[GitHub] spark pull request #18746: [ML][Python] UnaryTransformer in Python

2017-08-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r131257864 --- Diff: python/pyspark/ml/tests.py --- @@ -1957,6 +1987,24 @@ def test_chisquaretest(self): self.assertTrue(all(field in fieldNames for