Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136709446
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -151,29 +151,63 @@ class PredicateSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136709144
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -151,29 +151,63 @@ class PredicateSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136706140
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
+select 1 in(1, 2, 3);
+select 1
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136706025
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
--- End diff --
The test cases
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136704544
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
--- End diff --
Let me
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136704469
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
+select 1 in(1, 2, 3);
+select 1
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136704438
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
--- End diff --
If we do not
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136689620
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
+select 1 in(1, 2, 3);
+select 1
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136689567
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
+select 1 in(1, 2, 3);
+select 1
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136689245
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
--- End diff --
Actually I feel
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r136616723
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -0,0 +1,42 @@
+-- In
--- End diff --
Could we
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r132088990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -564,8 +611,27 @@ case class EqualNullSafe(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r132088507
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -564,8 +611,27 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r132084124
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -484,7 +501,20 @@ object Equality {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r132081911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -484,7 +501,20 @@ object Equality {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r131841212
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -600,8 +694,25 @@ case class GreaterThan(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r131754182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -484,7 +501,20 @@ object Equality {
}
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18869#discussion_r131638244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -600,8 +694,25 @@ case class GreaterThan(left:
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/18869
[SPARK-21654][SQL] Complement SQL predicates expression description
## What changes were proposed in this pull request?
SQL predicates don't have complete expression description. This patch
20 matches
Mail list logo
