[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r163831513 --- Diff: python/pyspark/sql/functions.py --- @@ -2105,6 +2105,14 @@ def udf(f=None, returnType=StringType()): >>> import random >>>

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-25 Thread ptkool
Github user ptkool commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r163828796 --- Diff: python/pyspark/sql/functions.py --- @@ -2105,6 +2105,14 @@ def udf(f=None, returnType=StringType()): >>> import random >>>

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r163759284 --- Diff: python/pyspark/sql/functions.py --- @@ -2105,6 +2105,14 @@ def udf(f=None, returnType=StringType()): >>> import random >>>

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r163757006 --- Diff: python/pyspark/sql/functions.py --- @@ -2264,6 +2272,16 @@ def pandas_udf(f=None, returnType=None, functionType=None): ...

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r163238156 --- Diff: python/pyspark/sql/udf.py --- @@ -180,17 +182,29 @@ def wrapper(*args): wrapper.deterministic = self.deterministic

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r162857718 --- Diff: python/pyspark/sql/functions.py --- @@ -2231,6 +2239,16 @@ def pandas_udf(f=None, returnType=None, functionType=None): ... return

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r162857996 --- Diff: python/pyspark/sql/tests.py --- @@ -602,6 +602,30 @@ def test_non_existed_udf(self): self.assertRaisesRegexp(AnalysisException, "Can

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r162857704 --- Diff: python/pyspark/sql/functions.py --- @@ -2103,6 +2103,14 @@ def udf(f=None, returnType=StringType()): >>> import random >>>

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r162779803 --- Diff: python/pyspark/sql/tests.py --- @@ -597,10 +597,29 @@ def test_non_existed_udf(self): self.assertRaisesRegexp(AnalysisException,

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159648955 --- Diff: python/pyspark/sql/udf.py --- @@ -163,14 +164,26 @@ def wrapper(*args): wrapper.returnType = self.returnType

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159415581 --- Diff: python/pyspark/sql/udf.py --- @@ -163,14 +164,25 @@ def wrapper(*args): wrapper.returnType = self.returnType

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159350021 --- Diff: python/pyspark/sql/udf.py --- @@ -17,6 +17,7 @@ """ User-defined function related classes and functions """ +import copy

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159349970 --- Diff: python/pyspark/sql/udf.py --- @@ -174,3 +178,12 @@ def asNondeterministic(self): """ self._deterministic = False

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159349251 --- Diff: python/pyspark/sql/udf.py --- @@ -174,3 +178,12 @@ def asNondeterministic(self): """ self._deterministic = False

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2018-01-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r159349953 --- Diff: python/pyspark/sql/udf.py --- @@ -174,3 +178,12 @@ def asNondeterministic(self): """ self._deterministic = False

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2017-12-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r158752315 --- Diff: python/pyspark/sql/tests.py --- @@ -1,3 +1,4 @@ + --- End diff -- Let's remove this line ---

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

2017-11-13 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r150733716 --- Diff: dev/sparktestsupport/modules.py --- @@ -389,18 +389,6 @@ def __hash__(self): "python/pyspark/sql" ],