[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r155518105 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r155454606 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r155185768 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r138681313 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r138680470 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r138525454 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18975 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929328 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929284 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929091 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,31 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929022 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929025 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137920269 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137919837 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137919207 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137919154 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137919040 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137919007 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918931 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,31 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918839 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918792 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918600 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137918571 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137916528 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,176 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137916510 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,31 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137680545 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,176 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137680153 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,31 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137629284 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,150 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137607929 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137607749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137607545 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137607475 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137606401 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137605940 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137605602 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala --- @@ -366,4 +367,43 @@ class InsertSuite extends DataSourceTest with

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137605509 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -140,6 +143,14 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137605311 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137601757 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137601572 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137601380 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -32,7 +32,8 @@ import

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137461450 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,150 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137460756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137460842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137456014 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455829 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455718 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137455095 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137454780 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137453643 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala --- @@ -366,4 +367,43 @@ class InsertSuite extends DataSourceTest with

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137453352 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452938 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -140,6 +143,14 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452482 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137452336 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137449077 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -524,6 +525,50 @@ class DDLParserSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137448976 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala --- @@ -32,7 +32,8 @@ import

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137406552 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -2346,6 +2347,45 @@ abstract class DDLSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137406502 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137403025 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -2346,6 +2347,45 @@ abstract class DDLSuite extends

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137401845 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137401720 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137401187 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -234,12 +82,8 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137401217 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137399745 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -234,12 +82,8 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137399408 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137398964 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137398917 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,27 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137398869 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,27 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137398776 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137398299 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137397811 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137388410 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,27 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137388263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,27 @@ case class

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137387725 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137387842 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137386317 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137385849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137106989 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -241,11 +241,21 @@ query : ctes? queryNoWith

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r13706 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137063137 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137063179 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137063033 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137062047 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137061444 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137060998 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,81 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137060557 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1509,4 +1509,86 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137058514 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1509,4 +1509,86 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137057860 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136740379 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136739979 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136739964 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136739990 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136739126 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136738263 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -241,11 +241,21 @@ query : ctes? queryNoWith

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136738182 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136727120 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to

  1   2   >