[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19148 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137706271 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137704899 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137704429 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137703092 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137700913 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137700499 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137699853 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137699802 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/SparkSubmitTestUtils.scala --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137699720 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137699367 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137686311 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to the

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137683665 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137682740 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137682115 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to

[GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...

2017-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19148#discussion_r137663570 --- Diff: sql/hive/pom.xml --- @@ -177,6 +177,10 @@ libfb303 + org.apache.derby + derby --- End