[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19196 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139840990 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EnsureStatefulOpPartitioningSuite.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139578185 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139578096 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139578010 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139577945 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139577898 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/IncrementalExecutionRulesSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139197660 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139083835 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139083752 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139079444 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139078992 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-15 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r139078823 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,187 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-14 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138988133 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -200,18 +202,31 @@ case class

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138759679 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -117,8 +119,33 @@ class IncrementalExecution(

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138761881 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138762394 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138760053 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -800,6 +800,7 @@ class StreamExecution( if

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138765597 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138771978 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138771941 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138760476 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -200,18 +202,31 @@ case class

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138762847 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -381,4 +388,233 @@ class StreamingAggregationSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138772306 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -873,6 +875,96 @@ class FlatMapGroupsWithStateSuite

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138771336 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -117,8 +119,33 @@ class IncrementalExecution(

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-13 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138756939 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -117,8 +119,33 @@ class IncrementalExecution(

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-12 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138414658 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -53,6 +53,8 @@ case class

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-12 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19196#discussion_r138414592 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -117,8 +119,33 @@ class IncrementalExecution(

[GitHub] spark pull request #19196: [SPARK-21977] SinglePartition optimizations break...

2017-09-11 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/19196 [SPARK-21977] SinglePartition optimizations break certain Streaming Stateful Aggregation requirements ## What changes were proposed in this pull request? This is a bit hard to explain as