Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19229
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r142021142
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2083,22 +2083,57 @@ class Dataset[T] private[sql](
* @group untypedrel
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r142021120
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2083,22 +2083,57 @@ class Dataset[T] private[sql](
* @group
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r142021066
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2083,22 +2083,57 @@ class Dataset[T] private[sql](
* @group
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r141999421
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r141976671
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140690182
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -223,20 +223,18 @@ class ImputerModel private[ml] (
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140689908
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -223,20 +223,18 @@ class ImputerModel private[ml] (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140680794
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140680654
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140680629
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140680435
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140678630
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140678574
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -223,20 +223,18 @@ class ImputerModel private[ml] (
override def
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140675967
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -223,20 +223,18 @@ class ImputerModel private[ml] (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19229#discussion_r140412254
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19229
[SPARK-22001][ML][SQL] ImputerModel can do withColumn for all input columns
at one pass
## What changes were proposed in this pull request?
SPARK-21690 makes one-pass `Imputer` by
17 matches
Mail list logo
