[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19243 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139884675 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,44 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139868488 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,44 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139665152 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,39 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139602239 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,39 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139602407 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,39 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139601709 --- Diff: R/pkg/R/DataFrame.R --- @@ -984,12 +984,12 @@ setMethod("unique", #' of the total count of of the given SparkDataFrame. #' #'

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139601790 --- Diff: R/pkg/R/DataFrame.R --- @@ -998,33 +998,39 @@ setMethod("unique", #' sparkR.session() #' path <- "path/to/file.json" #' df <-

[GitHub] spark pull request #19243: [SPARK-21780][R] Simpler Dataset.sample API in R

GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/19243 [SPARK-21780][R] Simpler Dataset.sample API in R ## What changes were proposed in this pull request? This PR make `sample(...)` able to omit `withReplacement` defaulting to `FALSE`,