[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r143421894 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java --- @@ -35,6 +35,11 @@ * if the fields of

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r143346155 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java --- @@ -35,6 +35,11 @@ * if the fields of

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r143343968 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java --- @@ -35,6 +35,11 @@ * if the fields

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r143343926 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java --- @@ -35,6 +35,11 @@ * if the fields

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19266 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139656129 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -39,7 +39,7 @@ private final long length;

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139616346 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -344,7 +344,7 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139616411 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -304,8 +304,8 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139616165 --- Diff: core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala --- @@ -126,22 +126,20 @@ private[spark] class CompactBuffer[T: ClassTag]

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139615624 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -39,7 +39,7 @@ private final long length;

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139615418 --- Diff: core/src/main/scala/org/apache/spark/util/collection/PartitionedPairBuffer.scala --- @@ -96,5 +96,5 @@ private[spark] class

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139582421 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -39,7 +39,7 @@ private final long length;

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139580567 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -39,7 +39,7 @@ private final long length;

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139492024 --- Diff: core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala --- @@ -126,22 +126,20 @@ private[spark] class CompactBuffer[T: ClassTag]

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139489658 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/HashMapGrowthStrategy.java --- @@ -30,11 +30,15 @@ HashMapGrowthStrategy DOUBLING = new

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

Github user buryat commented on a diff in the pull request: https://github.com/apache/spark/pull/19266#discussion_r139489491 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java --- @@ -39,7 +39,7 @@ private final long length;

[GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...

GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/19266 [SPARK-22033][CORE] BufferHolder, other size checks should account for the specific VM array size limitations ## What changes were proposed in this pull request? Try to avoid allocating an