Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19286
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140644507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638128
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -749,6 +749,34 @@ class JDBCSuite extends SparkFunSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r139887244
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -747,6 +747,19 @@ class JDBCSuite extends SparkFunSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r139878221
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -747,6 +747,19 @@ class JDBCSuite extends SparkFunSuite
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19286
[SPARK-21338][SQL][FOLLOW-UP] Implement isCascadingTruncateTable() method
in AggregatedDialect
## What changes were proposed in this pull request?
The implemented
