Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19321
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140764796
--- Diff: docs/sql-programming-guide.md ---
@@ -1553,6 +1553,7 @@ options.
## Upgrading From Spark SQL 2.2 to 2.3
- Since Spark 2.3, the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140684015
--- Diff: docs/sql-programming-guide.md ---
@@ -1553,6 +1553,7 @@ options.
## Upgrading From Spark SQL 2.2 to 2.3
- Since Spark 2.3,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140647928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -123,7 +124,13 @@ case
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140647683
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -134,7 +141,18 @@ case
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140627874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -85,7 +85,8 @@ case class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140429643
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentileSuite.scala
---
@@ -270,7 +270,6 @@ class
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19321
[SPARK-22100] [SQL] Make percentile_approx support numeric/date/timestamp
types
## What changes were proposed in this pull request?
Currently `percentile_approx` only supports double type.
