Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19449
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r206760031
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
---
@@ -82,4 +84,22 @@ class ExecutorSideSQLConfSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r202869932
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -751,6 +751,12 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r202833782
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -751,6 +751,12 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143385878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143351534
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143345610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143345568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143326066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143318406
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class CodegenContext {
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143312237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143307261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143306861
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143291724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19449
[SPARK-22219][SQL] Refactor code to get a value for
"spark.sql.codegen.comments"
## What changes were proposed in this pull request?
This PR refactors code to get a value for
15 matches
Mail list logo
