Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143640733
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -36,9 +37,7 @@
*/
public class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19460
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143571046
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,6 +40,15 @@ public static int
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143572060
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSuite.scala
---
@@ -37,3 +43,54 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143570916
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,6 +40,15 @@ public static int
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143564830
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,6 +40,15 @@ public static int
GitHub user liufengdb opened a pull request:
https://github.com/apache/spark/pull/19460
[SPARK-2][core] Fix the ARRAY_MAX in BufferHolder and add a test
## What changes were proposed in this pull request?
We should not break the assumption that the length of the
