[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19501 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19501#discussion_r144742648 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -636,4 +637,33 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19501#discussion_r144739274 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -636,4 +637,33 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19501 [SPARK-3][SQL] ObjectHashAggregate should not introduce unnecessary shuffle ## What changes were proposed in this pull request? `ObjectHashAggregateExec` should override