Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19556
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146896813
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,52 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146895110
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,52 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146895438
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -395,8 +435,13 @@ private[util] class FieldAccessFinder(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146895161
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146833044
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146771631
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146769438
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146763677
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146760101
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146759438
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146581086
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146577760
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146534666
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146426012
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,52 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146346452
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,52 @@ private[spark] object ClosureCleaner extends Logging {
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19556
[SPARK-22328][Core] ClosureCleaner should not miss referenced superclass
fields
## What changes were proposed in this pull request?
When the given closure uses some fields defined in super
17 matches
Mail list logo
