[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19638 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r150394001 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r150393944 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r150380973 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r149731177 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r149560345 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r149559666 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r149558607 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r149299091 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148919520 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148881376 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148869278 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148852449 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148852081 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148692614 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala --- @@ -125,4 +125,14 @@ class RegressionMetrics @Since("2.0.0")

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148662710 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -230,6 +230,13 @@ class MultivariateOnlineSummarizer

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148664242 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala --- @@ -125,4 +125,14 @@ class RegressionMetrics @Since("2.0.0") (

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148641672 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala --- @@ -73,6 +73,11 @@ class RegressionEvaluatorSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148634321 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -49,8 +49,8 @@ final class RegressionEvaluator

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148634479 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -722,6 +722,17 @@ class LinearRegressionSummary

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148626297 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -49,8 +49,8 @@ final class RegressionEvaluator

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148623948 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala --- @@ -73,6 +73,11 @@ class RegressionEvaluatorSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148619202 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -230,6 +230,13 @@ class MultivariateOnlineSummarizer

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148619618 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -230,6 +230,13 @@ class MultivariateOnlineSummarizer

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148585371 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -49,8 +49,8 @@ final class RegressionEvaluator

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148619734 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala --- @@ -73,6 +73,11 @@ class RegressionEvaluatorSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148618367 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -49,8 +49,8 @@ final class RegressionEvaluator

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148612789 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -49,8 +49,8 @@ final class RegressionEvaluator

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148461389 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -230,6 +230,12 @@ class MultivariateOnlineSummarizer

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148460065 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala --- @@ -125,4 +125,14 @@ class RegressionMetrics @Since("2.0.0") (

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148461468 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateStatisticalSummary.scala --- @@ -44,6 +44,8 @@ trait MultivariateStatisticalSummary

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

GitHub user tengpeng opened a pull request: https://github.com/apache/spark/pull/19638 [SPARK-22422][ML] Add Adjusted R2 to RegressionMetrics ## What changes were proposed in this pull request? I added adjusted R2 as a regression metric which was implemented in all major