Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19707
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150069049
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1408,6 +1409,23 @@ class DatasetSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150064768
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1408,6 +1409,23 @@ class DatasetSuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150027756
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1408,6 +1409,23 @@ class DatasetSuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150026840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -134,7 +134,13 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150024246
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1408,6 +1409,23 @@ class DatasetSuite extends QueryTest with
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19707#discussion_r150015018
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1408,6 +1409,23 @@ class DatasetSuite extends QueryTest with
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19707
[SPARK-22472][SQL] add null check for top-level primitive values
## What changes were proposed in this pull request?
One powerful feature of `Dataset` is, we can easily map SQL rows to