Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19728
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151741098
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -125,19 +138,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151740628
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -125,19 +138,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151738992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151482932
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,32 @@ case class Concat(children:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151478604
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,32 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r151478304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,32 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150590456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150579715
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150577735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150573152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150567337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150564483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +143,41 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150516641
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +139,36 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150516546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150470069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150469779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150469019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150468020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150467377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150461348
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150460595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,28 @@ case class Concat(children:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150454183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -163,13 +190,18 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150454166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,26 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150444966
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +137,34 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150444902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,26 @@ case class Concat(children:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150444269
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,26 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150441354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -163,13 +190,18 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150441287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -63,15 +63,26 @@ case class Concat(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19728#discussion_r150441323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -126,18 +137,34 @@ case class
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19728
[SPARK-22498][SQL] Fix 64KB JVM bytecode limit problem with concat and
concat_ws
## What changes were proposed in this pull request?
This PR changes `concat` and `concat_ws` code generation
31 matches
Mail list logo