Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19776
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152429647
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,231 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152425778
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,231 @@
+/*
+ *
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421950
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152422048
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421982
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,9 +296,15 @@ class JDBCSuite extends SparkFunSuite
// The
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152263922
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152263135
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152261544
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,9 +296,15 @@ class JDBCSuite extends SparkFunSuite
// The
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152260557
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object DataSourceStrategy {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152206765
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200656
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
//
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200310
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200223
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200130
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200166
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200090
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200107
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193847
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,306 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193833
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152192018
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,306 @@
+/*
+ *
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191858
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ *
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191659
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ *
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191430
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152190564
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ *
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152186116
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
// The
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152158653
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
// The
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152156940
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
//
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152156397
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152137096
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
// The
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152136470
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object DataSourceStrategy {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151962055
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
//
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151960214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object DataSourceStrategy
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151922970
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object DataSourceStrategy {
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151920447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object DataSourceStrategy {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151920212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object DataSourceStrategy {
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151920126
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object DataSourceStrategy {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151917654
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151916997
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151901160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object DataSourceStrategy {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151900595
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/19776
[SPARK-22548][SQL] Incorrect nested AND expression pushed down to JDBâ¦
â¦C data source
## What changes were proposed in this pull request?
Letâs say I have a nested AND
43 matches
Mail list logo
