Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19777#discussion_r207077435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -125,13 +125,34 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19777
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19777#discussion_r152045624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -163,13 +184,36 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19777#discussion_r151953946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -125,19 +125,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19777#discussion_r151951926
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -125,19 +125,43 @@ case class
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19777
[SPARK-22549][SQL] Fix 64KB JVM bytecode limit problem with concat_ws
## What changes were proposed in this pull request?
This PR changes `concat_ws` code generation to place generated code