[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r152168668 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -76,20 +76,23 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151967403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -83,11 +83,12 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151966937 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -83,11 +83,12 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151963572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -76,7 +76,7 @@ case class BroadcastHashJoinExec(

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151963108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -76,7 +76,7 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151961655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -90,6 +90,10 @@ case class BroadcastHashJoinExec(

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151959078 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -90,6 +90,10 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151953815 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala --- @@ -124,9 +124,11 @@ case class SortExec( // Name of sorter

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151924692 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala --- @@ -124,9 +124,11 @@ case class SortExec( // Name of sorter

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-18 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/19781 [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCopyResult in Sort, HashAggregate, and BroadcastHashJoin ## What changes were proposed in this pull request? I found #19656 causes some