[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-12-05 Thread kellyzly
Github user kellyzly commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r155083419 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -169,8 +169,10 @@ public static ByteBuffer allocateDirectBuffer(int

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-12-05 Thread kellyzly
Github user kellyzly commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r155080359 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -296,7 +296,8 @@ class

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154266377 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -424,7 +426,9 @@ case class HiveScriptIOSchema

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154266308 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -412,7 +412,9 @@ case class HiveScriptIOSchema

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154266187 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -296,7 +296,8 @@ class

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154266242 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -412,7 +412,9 @@ case class HiveScriptIOSchema

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154265720 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -296,7 +296,8 @@ class

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154154221 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -412,7 +412,9 @@ case class HiveScriptIOSchema

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154154076 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -169,8 +169,10 @@ public static ByteBuffer allocateDirectBuffer(int

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19854#discussion_r154138361 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -99,7 +99,7 @@ private[spark] class TorrentBroadcast[T:

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

2017-11-30 Thread kellyzly
GitHub user kellyzly opened a pull request: https://github.com/apache/spark/pull/19854 SPARK-22660:Use position() and limit() to fix ambiguity issue in scal… …a-2.12 and JDK9 ## What changes were proposed in this pull request? (Please fill in changes proposed