Github user gczsjdy closed the pull request at:
https://github.com/apache/spark/pull/19862
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r156581645
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154635850
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154568554
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154568281
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +154,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -750,6 +756,8 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567585
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -182,18 +183,14 @@ public UnsafeRow next() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567319
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154567168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566463
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -700,38 +701,43 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154566374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154563897
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154564327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154564488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154556774
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java
---
@@ -159,6 +159,12 @@ public boolean hasNext() {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154558106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560155
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -699,39 +700,44 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560524
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -674,8 +674,9 @@ private[joins] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19862#discussion_r154560474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -750,6 +756,8 @@ private[joins] class
20 matches
Mail list logo
