Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19869
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154682180
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -596,7 +596,7 @@ case class HashAggregateExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154580311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -596,7 +596,7 @@ case class HashAggregateExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154576368
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -573,94 +574,84 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154569858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154569741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154566445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -882,45 +851,65 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154565659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154561232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -621,34 +622,30 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154562413
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154556638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154534333
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528578
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -882,45 +851,65 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528498
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -784,86 +774,65 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528455
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -784,86 +774,65 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528431
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528409
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -672,48 +668,56 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154528386
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -444,6 +444,7 @@ case class HashAggregateExec(
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19869
[SPARK-22677][SQL] cleanup whole stage codegen for hash aggregate
## What changes were proposed in this pull request?
The `HashAggregateExec` whole stage codegen path is a little messy
19 matches
Mail list logo
