Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19873
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r155130916
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -321,39 +319,40 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r155129282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -881,3 +881,10 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r155129278
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala
---
@@ -23,8 +23,8 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r155064881
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala
---
@@ -23,8 +23,8 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r155064613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -881,3 +881,10 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154896108
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -50,41 +50,6 @@ abstract class LogicalPlan
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154863367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -280,7 +280,7 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154863115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -280,7 +280,7 @@ object TypeCoercion {
*/
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154863020
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -470,7 +470,7 @@ case class DataSource(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154863033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1073,11 +1076,13 @@ class Analyzer(
* The
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154862947
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -241,7 +241,7 @@ class PlannerSuite extends SharedSQLContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154863003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -666,7 +667,9 @@ class Analyzer(
* Generate a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154859083
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1098,7 +1103,8 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154858997
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -666,7 +667,9 @@ class Analyzer(
*
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154859044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1073,11 +1076,13 @@ class Analyzer(
* The
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154858146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -470,7 +470,7 @@ case class DataSource(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154857858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -666,7 +667,9 @@ class Analyzer(
*
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154857587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -280,7 +280,7 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154855592
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -241,7 +241,7 @@ class PlannerSuite extends SharedSQLContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19873#discussion_r154855150
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -50,41 +50,6 @@ abstract class LogicalPlan
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19873
[SPARK-20392][SQL] Set barrier to prevent re-entering a tree
## What changes were proposed in this pull request?
It is reported that there is performance downgrade when applying ML
22 matches
Mail list logo
