[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19882 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155429024 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155428391 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155410507 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155398123 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,370 @@ +/* + * Licensed

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155395310 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155394617 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155392637 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala --- @@ -15,20 +15,51 @@ * limitations under the

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155391390 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -225,57 +162,39 @@ abstract class

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155390570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155390445 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155230769 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155228866 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -225,57 +162,39 @@ abstract class

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155229015 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala --- @@ -15,20 +15,51 @@ * limitations under the

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155227254 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155168400 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala --- @@ -15,20 +15,51 @@ * limitations under the

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155168072 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155167981 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155167645 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcPartitionDiscoverySuite.scala --- @@ -186,8 +159,8 @@ class

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155167566 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155167305 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155167070 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala --- @@ -15,20 +15,51 @@ * limitations under the

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155166536 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcPartitionDiscoverySuite.scala --- @@ -186,8 +159,8 @@ class

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155060037 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,370 @@ +/* + * Licensed

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155058455 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,370 @@ +/* + * Licensed to

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r154843730 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,11 +531,63 @@ class OrcQuerySuite

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r154824305 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,11 +531,63 @@ class OrcQuerySuite extends

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/19882 [SPARK-22672][SQL][TEST] Refactor ORC Tests ## What changes were proposed in this pull request? Since SPARK-20682, we have two `OrcFileFormat`s. This PR refactors ORC tests with the