Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r161397435
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -91,7 +91,7 @@ public long position() {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r161391299
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -91,7 +91,7 @@ public long position() {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r161391208
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -91,7 +91,7 @@ public long position() {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r161390222
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -91,7 +91,7 @@ public long position() {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19884
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158212056
--- Diff: python/pyspark/sql/functions.py ---
@@ -2141,22 +2141,23 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
>>>
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158211101
--- Diff: python/pyspark/sql/functions.py ---
@@ -2141,22 +2141,23 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
>>>
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158208592
--- Diff: python/pyspark/sql/functions.py ---
@@ -2141,22 +2141,22 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
>>>
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158206546
--- Diff: python/pyspark/sql/utils.py ---
@@ -110,3 +110,12 @@ def toJArray(gateway, jtype, arr):
for i in range(0, len(arr)):
jarr[i]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158206309
--- Diff: python/pyspark/sql/utils.py ---
@@ -110,3 +110,12 @@ def toJArray(gateway, jtype, arr):
for i in range(0, len(arr)):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158206051
--- Diff: python/pyspark/sql/functions.py ---
@@ -2141,22 +2141,22 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
>>>
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158205751
--- Diff: python/pyspark/sql/tests.py ---
@@ -3356,6 +3356,7 @@ def test_schema_conversion_roundtrip(self):
self.assertEquals(self.schema,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158173623
--- Diff: python/pyspark/sql/tests.py ---
@@ -3356,6 +3356,7 @@ def test_schema_conversion_roundtrip(self):
self.assertEquals(self.schema,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r158112470
--- Diff: python/pyspark/sql/tests.py ---
@@ -3356,6 +3356,7 @@ def test_schema_conversion_roundtrip(self):
self.assertEquals(self.schema,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157961467
--- Diff: python/pyspark/sql/udf.py ---
@@ -33,6 +33,10 @@ def _wrap_function(sc, func, returnType):
def _create_udf(f, returnType,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157960643
--- Diff: python/pyspark/sql/udf.py ---
@@ -33,6 +33,10 @@ def _wrap_function(sc, func, returnType):
def _create_udf(f, returnType,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157958862
--- Diff: python/pyspark/sql/udf.py ---
@@ -33,6 +33,10 @@ def _wrap_function(sc, func, returnType):
def _create_udf(f, returnType,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157957465
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
---
@@ -126,18 +121,14 @@ class ArrowPythonRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157952725
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157952778
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157761407
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157747561
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157738702
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157738359
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157737242
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157692179
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157686204
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
---
@@ -126,18 +121,14 @@ class ArrowPythonRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157683878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
---
@@ -126,18 +121,14 @@ class ArrowPythonRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157683384
--- Diff: python/pyspark/sql/types.py ---
@@ -1679,6 +1678,15 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157677769
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -86,21 +86,16 @@ private[sql] object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157420989
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -86,21 +86,16 @@ private[sql] object ArrowConverters {
31 matches
Mail list logo