Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19977
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r159065306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -653,7 +660,11 @@ object CombineConcats extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r159048727
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -653,7 +660,11 @@ object CombineConcats extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158942832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -645,11 +646,16 @@ object CombineConcats extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158941617
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,34 @@ object TypeCoercion {
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158941360
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158939942
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158936746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -645,11 +646,16 @@ object CombineConcats extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158935640
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,34 @@ object TypeCoercion {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158920201
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158913138
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158893226
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,93 @@
+-- Concatenate mixed inputs (output type
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158892653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,33 @@ object TypeCoercion {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158892598
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,33 @@ object TypeCoercion {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158890414
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,34 @@ object TypeCoercion {
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158885096
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -645,11 +646,16 @@ object CombineConcats extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158885026
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158628810
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,17 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158629172
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -645,11 +646,16 @@ object CombineConcats extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158629277
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,34 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158629257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,34 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158628962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -645,11 +646,16 @@ object CombineConcats extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158572201
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2171,7 +2171,8 @@ object functions {
def base64(e: Column): Column =
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158501454
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2171,7 +2171,8 @@ object functions {
def base64(e: Column): Column =
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158429095
--- Diff:
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out ---
@@ -42,7 +42,7 @@ struct
== Analyzed Logical Plan ==
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158428849
--- Diff:
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out ---
@@ -42,7 +42,7 @@ struct
== Analyzed Logical Plan ==
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158339454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,37 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158337643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -73,17 +93,27 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158327829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,30 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158327166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -73,17 +93,27 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158326164
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,37 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158325851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,37 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158005532
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158004864
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157943490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157942499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157941723
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java ---
@@ -74,4 +74,29 @@ public static long getPrefix(byte[] bytes) {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157941423
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java ---
@@ -74,4 +74,29 @@ public static long getPrefix(byte[] bytes) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940623
--- Diff: docs/sql-programming-guide.md ---
@@ -1780,6 +1780,8 @@ options.
- Since Spark 2.3, when either broadcast hash join or broadcast
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940634
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940412
--- Diff: docs/sql-programming-guide.md ---
@@ -1780,6 +1780,8 @@ options.
- Since Spark 2.3, when either broadcast hash join or broadcast
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940334
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java ---
@@ -74,4 +74,29 @@ public static long getPrefix(byte[] bytes) {
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157939820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,26 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157937149
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,21 @@
+-- Concatenate binary inputs
+SELECT
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157936581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157935878
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,21 @@
+-- Concatenate binary inputs
--- End
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157935899
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,21 @@
+-- Concatenate binary inputs
+SELECT
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157935707
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -635,6 +635,11 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157935282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1044,6 +1044,12 @@ object SQLConf {
"When this
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157913293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,26 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157913170
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -564,6 +565,16 @@ object TypeCoercion {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157911342
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,25 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157899981
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,26 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157904983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -73,17 +82,25 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157899407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -564,6 +565,16 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157904626
--- Diff: docs/sql-programming-guide.md ---
@@ -1779,6 +1779,8 @@ options.
- Since Spark 2.3, when either broadcast hash join or broadcast
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157897765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -479,9 +480,9 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157905810
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -24,3 +24,25 @@ select left("abcd", 2), left("abcd", 5), left("abcd",
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157905624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -642,15 +642,17 @@ object CombineConcats extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157826372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1035,6 +1035,12 @@ object SQLConf {
.booleanConf
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157819483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -48,17 +48,26 @@ import
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157793004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1035,6 +1035,12 @@ object SQLConf {
.booleanConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157423020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1035,6 +1035,12 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157419618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1035,6 +1035,12 @@ object SQLConf {
.booleanConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157419028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157367539
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157361039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157125671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122586
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157116687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157113499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/19977
[SPARK-22771][SQL] Concatenate binary inputs into a binary output
## What changes were proposed in this pull request?
This pr modified `concat` to concat binary inputs into a single binary
77 matches
Mail list logo
