Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19981
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r158183772
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -48,7 +48,7 @@ private[spark] class AppStatusListener(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r158170972
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -48,7 +48,7 @@ private[spark] class AppStatusListener(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r158171335
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLHistoryServerPlugin.scala
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157829182
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -322,15 +321,18 @@ private[history] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157663383
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -147,236 +159,246 @@ class SQLListenerSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157663315
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -36,11 +36,12 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157662992
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -322,15 +321,18 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157582718
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,288 +155,274 @@ class SQLListenerSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157585557
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -517,9 +516,12 @@ class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157581481
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsTestUtils.scala
---
@@ -31,16 +31,13 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157584958
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -36,11 +36,12 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157582494
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,288 +155,274 @@ class SQLListenerSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157581053
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -167,6 +168,24 @@ case class SparkListenerApplicationEnd(time: Long)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157580676
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157497701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157496956
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157397655
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -489,16 +501,17 @@ private case class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r15724
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157331435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157323132
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,286 +163,277 @@ class SQLListenerSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157317442
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,286 +163,277 @@ class SQLListenerSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157315586
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -36,14 +36,23 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157312759
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -489,16 +501,17 @@ private case class MyPlan(sc:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157312345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157154532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157154044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157153841
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157137789
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157136615
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157136099
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -489,16 +501,17 @@ private case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157135896
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,286 +163,277 @@ class SQLListenerSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157135580
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,286 +163,277 @@ class SQLListenerSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157135495
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -142,286 +163,277 @@ class SQLListenerSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157135252
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -36,14 +36,23 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157135091
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157134291
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala
---
@@ -25,21 +25,17 @@ import
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19981
[SPARK-22786][SQL] only use AppStatusPlugin in history server
## What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/19681 we introduced a new
38 matches
Mail list logo
