Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19993
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r163562784
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +390,24 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r163561075
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -20,8 +20,11 @@ package org.apache.spark.ml.param
import
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162955686
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +390,14 @@ class BucketizerSuite extends SparkFunSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162940665
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +390,14 @@ class BucketizerSuite extends SparkFunSuite with
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162747183
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162719519
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162717263
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -166,6 +167,8 @@ private[ml] object Param {
@DeveloperApi
object
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162717142
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162044954
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162043704
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162042318
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161699705
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161685200
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161684970
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161681586
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r161682506
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +390,9 @@ class BucketizerSuite extends SparkFunSuite with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r160143590
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159579102
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159133936
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159100390
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,45 @@ object ParamsSuite extends SparkFunSuite {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159100191
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,27 @@ object ParamValidators {
def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159099688
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -137,18 +137,10 @@ final class Bucketizer @Since("1.4.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159100299
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -401,15 +401,9 @@ class BucketizerSuite extends SparkFunSuite with
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158344862
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,31 @@ object ParamValidators {
def
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158170154
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,49 @@ object ParamsSuite extends SparkFunSuite {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158158375
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,49 @@ object ParamsSuite extends SparkFunSuite {
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158154050
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,49 @@ object ParamsSuite extends SparkFunSuite {
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158153277
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,49 @@ object ParamsSuite extends SparkFunSuite {
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158153048
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,31 @@ object ParamValidators {
def
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157870176
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,29 @@ object ParamValidators {
def
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157871042
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,29 @@ object ParamValidators {
def
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157867496
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -137,18 +137,17 @@ final class Bucketizer @Since("1.4.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157870214
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,29 @@ object ParamValidators {
def
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157869596
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +250,29 @@ object ParamValidators {
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157684803
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -140,10 +140,10 @@ final class Bucketizer @Since("1.4.0")
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157414340
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -140,10 +140,10 @@ final class Bucketizer @Since("1.4.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r157393913
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -140,10 +140,10 @@ final class Bucketizer @Since("1.4.0")
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19993
[SPARK-22799][ML] Bucketizer should throw exception if single- and
multi-column params are both set
## What changes were proposed in this pull request?
Currently there is a mixed
39 matches
Mail list logo
