[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20004 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r159010802 --- Diff: python/pyspark/sql/streaming.py --- @@ -621,6 +621,10 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r159010566 --- Diff: python/pyspark/sql/streaming.py --- @@ -621,6 +621,10 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r158576836 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -148,6 +149,9 @@ class CSVOptions(

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157545088 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -482,6 +482,37 @@ class CSVSuite extends

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-17 Thread ep1804
Github user ep1804 commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157391252 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -482,6 +482,36 @@ class CSVSuite extends QueryTest

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-17 Thread ep1804
Github user ep1804 commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157391233 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -482,6 +482,36 @@ class CSVSuite extends QueryTest

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-17 Thread ep1804
Github user ep1804 commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157391102 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -249,6 +249,8 @@ final class DataStreamReader

[GitHub] spark pull request #20004: [Spark-22818][SQL] csv escape of quote escape

2017-12-17 Thread ep1804
Github user ep1804 commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157389005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -249,6 +249,8 @@ final class DataStreamReader

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157375137 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -249,6 +249,8 @@ final class DataStreamReader

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157374969 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -249,6 +249,8 @@ final class DataStreamReader

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157374876 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -482,6 +482,36 @@ class CSVSuite extends

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157374697 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -482,6 +482,36 @@ class CSVSuite extends

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20004#discussion_r157374638 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -249,6 +249,8 @@ final class DataStreamReader

[GitHub] spark pull request #20004: [Spark 22818][SQL] csv escape of quote escape

2017-12-17 Thread ep1804
GitHub user ep1804 opened a pull request: https://github.com/apache/spark/pull/20004 [Spark 22818][SQL] csv escape of quote escape ## What changes were proposed in this pull request? Escape of escape should be considered when using the UniVocity csv encoding/decoding