[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for FunctionArgum...

2017-12-19 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20008#discussion_r157920327 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/functionArgumentConversion.sql --- @@ -25,7 +25,7 @@ SELECT array(cast(1 as

[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for FunctionArgum...

2017-12-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20008#discussion_r157685985 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalPrecision.sql --- @@ -0,0 +1,6883 @@ +-- +-- Licensed to

[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for FunctionArgum...

2017-12-18 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20008#discussion_r157651436 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalPrecision.sql --- @@ -0,0 +1,6883 @@ +-- +-- Licensed to the

[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for FunctionArgum...

2017-12-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20008#discussion_r157548119 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalPrecision.sql --- @@ -0,0 +1,6883 @@ +-- +-- Licensed to

[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for FunctionArgum...

2017-12-18 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/20008 [SPARK-22822][TEST] Basic tests for FunctionArgumentConversion and DecimalPrecision ## What changes were proposed in this pull request? Test Coverage for `FunctionArgumentConversion` and