Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20015
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157925994
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,181 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157926202
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -563,6 +563,76 @@ class DateTimeUtilsSuite
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157926055
--- Diff: python/pyspark/sql/functions.py ---
@@ -,6 +,24 @@ def trunc(date, format):
return
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157908622
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,183 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157908653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,183 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157896273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -964,7 +981,62 @@ object DateTimeUtils {
}
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157905770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,183 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157902164
--- Diff: python/pyspark/sql/functions.py ---
@@ -,6 +,24 @@ def trunc(date, format):
return
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157902098
--- Diff: python/pyspark/sql/functions.py ---
@@ -,6 +,24 @@ def trunc(date, format):
return
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157821540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157686437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157676669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157678588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157680290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -944,9 +954,16 @@ object DateTimeUtils {
date
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157674840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157673626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157677311
--- Diff: python/pyspark/sql/functions.py ---
@@ -,6 +,24 @@ def trunc(date, format):
return
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157677136
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2797,6 +2797,21 @@ object functions {
TruncDate(date.expr,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157677400
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2797,6 +2797,21 @@ object functions {
TruncDate(date.expr,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157673559
--- Diff: python/pyspark/sql/functions.py ---
@@ -,6 +,24 @@ def trunc(date, format):
return
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20015#discussion_r157675835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1295,87 +1295,184 @@ case class
22 matches
Mail list logo
