Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20133
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159431742
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1366,6 +1388,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159431317
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1180,7 +1202,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159431206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1104,28 +1118,36 @@ class SparkSqlAstBuilder(conf:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159364965
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1180,7 +1202,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159364941
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1366,6 +1388,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159364923
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1104,28 +1118,36 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159364557
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -383,23 +383,34 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159269896
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1971,8 +1971,8 @@ abstract class DDLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159170627
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -875,12 +875,13 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159170624
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1971,8 +1971,8 @@ abstract class DDLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159170240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -384,22 +384,31 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159170197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -408,9 +417,17 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159170195
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -39,6 +41,17 @@ object ParserUtils {
throw
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159168832
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -1153,65 +1191,165 @@ class DDLParserSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159168804
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -875,12 +875,13 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159168759
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1971,8 +1971,8 @@ abstract class DDLSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159150554
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -384,22 +384,31 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159164626
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -408,9 +417,17 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159156756
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -39,6 +41,17 @@ object ParserUtils {
throw new
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20133
[SPARK-22934] [SQL] Make optional clauses order insensitive for CREATE
TABLE SQL statement
## What changes were proposed in this pull request?
Currently, our CREATE TABLE syntax require the
21 matches
Mail list logo
