Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r164019336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r164017562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20224
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163947756
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163944914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163799937
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,38 @@ class WholeStageCodegenSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163790082
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,38 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163784607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163784286
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,32 @@ object WholeStageCodegenExec {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163774923
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163773528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,14 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163773516
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163773021
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,14 @@ object SQLConf {
.booleanConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163771658
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163771343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,14 @@ object SQLConf {
.booleanConf
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163771262
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163770850
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,32 @@ object WholeStageCodegenExec {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163769201
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163767104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,13 @@ object SQLConf {
.booleanConf
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163757952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,28 @@ object WholeStageCodegenExec {
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163757687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,13 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163748166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,28 @@ object WholeStageCodegenExec {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163747941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,13 @@ object SQLConf {
.booleanConf
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163461361
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -365,6 +388,26 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163456017
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,21 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163453639
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,21 @@ class WholeStageCodegenSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163449472
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,21 @@ class WholeStageCodegenSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163449646
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -365,6 +388,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161981976
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -312,6 +313,24 @@ case class InputAdapter(child:
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161980740
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -575,7 +609,10 @@ case class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161979484
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -312,6 +313,24 @@ case class InputAdapter(child:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161387055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -575,7 +609,10 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161381362
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -312,6 +313,24 @@ case class InputAdapter(child:
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20224
[SPARK-23032][SQL] Add a per-query codegenStageId to WholeStageCodegenExec
## What changes were proposed in this pull request?
**Proposal**
Add a per-query ID to the codegen
34 matches
Mail list logo