Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20229
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20229#discussion_r161345610
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -17,18 +17,29 @@
package org.apache.spark.ml.feature
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20229#discussion_r161345515
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -25,7 +25,7 @@ import org.apache.hadoop.fs.Path
import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20229#discussion_r161344579
--- Diff: R/pkg/R/mllib_utils.R ---
@@ -130,3 +130,4 @@ read.ml <- function(path) {
stop("Unsupported model: ", jobj)
}
}
+
---
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20229#discussion_r161153997
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -230,16 +231,17 @@ class RFormula @Since("1.5.0") (@Since("1.5.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20229#discussion_r161120354
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -230,16 +231,17 @@ class RFormula @Since("1.5.0") (@Since("1.5.0")
