Github user cloud-fan closed the pull request at:
https://github.com/apache/spark/pull/20276
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162431289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -902,9 +902,20 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162262776
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -318,7 +318,10 @@ class Analyzer(
gid:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162262684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -318,7 +318,10 @@ class Analyzer(
gid:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162259637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -730,12 +733,28 @@ class Analyzer(
right
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162257509
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -318,7 +318,10 @@ class Analyzer(
gid:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r162018508
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1234,11 +1234,24 @@ class Dataset[T] private[sql](
if
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20276#discussion_r161980194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
---
@@ -76,11 +76,11 @@ class InnerJoinSuite extends
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20276
[SPARK-14948][SQL] disambiguate attributes in join condition
## What changes were proposed in this pull request?
`Dataset.col/apply` returns a column reference, which is pretty useful to
