[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162448507 --- Diff: python/pyspark/sql/udf.py --- @@ -181,3 +183,179 @@ def asNondeterministic(self): """ self.deterministic = False

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20288 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162229716 --- Diff: python/pyspark/sql/context.py --- @@ -29,9 +29,10 @@ from pyspark.sql.readwriter import DataFrameReader from pyspark.sql.streaming

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162230241 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,29 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162198033 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +224,20 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162089110 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +224,20 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035869 --- Diff: python/pyspark/sql/udf.py --- @@ -181,3 +183,179 @@ def asNondeterministic(self): """ self.deterministic = False

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035576 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,34 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035758 --- Diff: python/pyspark/sql/udf.py --- @@ -181,3 +183,179 @@ def asNondeterministic(self): """ self.deterministic = False

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035427 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,34 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035316 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,34 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162035180 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +224,20 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162031948 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,34 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162031848 --- Diff: python/pyspark/sql/context.py --- @@ -172,113 +173,34 @@ def range(self, start, end=None, step=1, numPartitions=None): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162031680 --- Diff: python/pyspark/sql/udf.py --- @@ -181,3 +183,180 @@ def asNondeterministic(self): """ self.deterministic = False

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162031475 --- Diff: python/pyspark/sql/udf.py --- @@ -181,3 +183,180 @@ def asNondeterministic(self): """ self.deterministic = False

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161983722 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +225,18 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161969687 --- Diff: python/pyspark/sql/context.py --- @@ -147,7 +147,8 @@ def udf(self): :return: :class:`UDFRegistration` """ -

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161966469 --- Diff: python/pyspark/sql/session.py --- @@ -778,6 +778,146 @@ def __exit__(self, exc_type, exc_val, exc_tb): self.stop()

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161964247 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +225,18 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161964383 --- Diff: python/pyspark/sql/context.py --- @@ -147,7 +147,8 @@ def udf(self): :return: :class:`UDFRegistration` """ -

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161966507 --- Diff: python/pyspark/sql/session.py --- @@ -778,6 +778,146 @@ def __exit__(self, exc_type, exc_val, exc_tb): self.stop()

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161965369 --- Diff: python/pyspark/sql/session.py --- @@ -778,6 +778,146 @@ def __exit__(self, exc_type, exc_val, exc_tb): self.stop()

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161965278 --- Diff: python/pyspark/sql/context.py --- @@ -624,6 +536,9 @@ def _test(): globs['os'] = os globs['sc'] = sc

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161964738 --- Diff: python/pyspark/sql/session.py --- @@ -778,6 +778,146 @@ def __exit__(self, exc_type, exc_val, exc_tb): self.stop()

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-16 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/20288 [SPARK-23122][PYTHON][SQL] Deprecate register* for UDFs in SQLContext and Catalog in PySpark ## What changes were proposed in this pull request? This PR proposes to deprecate