Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r163119635
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r163014278
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20297
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162851582
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162694343
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -331,23 +358,27 @@ protected void handle(Message msg) throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162694174
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -331,23 +358,27 @@ protected void handle(Message msg) throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162693890
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -95,15 +95,15 @@ protected synchronized void send(Message msg)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162693731
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162550217
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162548031
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -95,15 +95,15 @@ protected synchronized void send(Message
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162525240
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -331,23 +358,27 @@ protected void handle(Message msg) throws
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162525142
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -331,23 +358,27 @@ protected void handle(Message msg) throws
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162524725
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -95,15 +95,15 @@ protected synchronized void send(Message msg)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162524615
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162159354
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -331,23 +358,27 @@ protected void handle(Message msg) throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r162159436
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -381,7 +381,9 @@ private object
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20297
[SPARK-23020][CORE] Fix races in launcher code, test.
The race in the code is because the handle might update
its state to the wrong state if the connection handling
thread is still
17 matches
Mail list logo
